pmdas: comment out default configurations

[sfeifer]

The .conf files for certain pmdas ship active default credentials (i.e. username and password). When a user installs these pmdas with a matching database, the pmdas will silently authenticate without any warnings that there are configurations that must be set. This PR comments out those fields with a clear CHANGE_ME placeholder to prevent silent authentication and inform users that these fields must be configured for the service they want to monitor.

Summary by CodeRabbit

• Configuration
  • Default connection templates for SAP HANA, MSSQL, Oracle, PostgreSQL, and RabbitMQ no longer include active credentials. Users must explicitly supply or uncomment credential values in their configuration files before connecting.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 678b5933-456e-4da6-9583-4aca34678070

📥 Commits

Reviewing files that changed from the base of the PR and between 83e6597 and 5010921.

📒 Files selected for processing (5)

• src/pmdas/hdb/hdb.conf
• src/pmdas/mssql/mssql.conf
• src/pmdas/oracle/sample.conf
• src/pmdas/postgresql/pmdapostgresql.conf
• src/pmdas/rabbitmq/rabbitmq.conf

✅ Files skipped from review due to trivial changes (3)

• src/pmdas/hdb/hdb.conf
• src/pmdas/mssql/mssql.conf
• src/pmdas/postgresql/pmdapostgresql.conf

🚧 Files skipped from review as they are similar to previous changes (1)

• src/pmdas/oracle/sample.conf

---

📝 Walkthrough

Walkthrough

Five PMDA configuration files remove hardcoded authentication credentials and replace them with commented placeholder values (CHANGE_ME). Users must now explicitly configure credentials for SAP HANA, SQL Server, Oracle, PostgreSQL, and RabbitMQ monitoring agents.

Changes

Credential Hardening Across PMDA Configs

Layer / File(s)

Summary

Replace hardcoded PMDA credentials with placeholders src/pmdas/hdb/hdb.conf, src/pmdas/mssql/mssql.conf, src/pmdas/oracle/sample.conf, src/pmdas/postgresql/pmdapostgresql.conf, src/pmdas/rabbitmq/rabbitmq.conf

SAP HANA changes user=user and password=password to #user=CHANGE_ME and #password=CHANGE_ME. SQL Server replaces username=sa and password=P4$$W0rd with #username=CHANGE_ME and #password=CHANGE_ME. Oracle updates $username and $password from 'oastoltp' to commented 'CHANGE_ME' placeholders and adds a preface comment. PostgreSQL adds an [authentication] section and converts active settings to commented templates with CHANGE_ME placeholders. RabbitMQ replaces username = guest and password = guest with #username = CHANGE_ME and #password = CHANGE_ME.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Credentials tucked away, no secrets on display,
Five files now whisper "CHANGE_ME" by day.
A hop, a sniff, a careful config chore,
Set them right, and monitoring will soar!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'pmdas: comment out default configurations' directly and clearly describes the main change across all modified files - commenting out hardcoded default credentials in configuration files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}