Support files with encoding other than UTF-8.#188
Open
chrullrich wants to merge 1 commit intoperitus:masterfrom
chrullrich:codecs-encoding
Open
Support files with encoding other than UTF-8.#188chrullrich wants to merge 1 commit intoperitus:masterfrom chrullrich:codecs-encoding
chrullrich wants to merge 1 commit intoperitus:masterfrom
chrullrich:codecs-encoding
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows bumpversion to be used with files that are not encoded in a way compatible with UTF-8. My particular use case is Visual C++ resource scripts, which are, unfortunately, in UTF-16LE encoding.
Tests pass with Python 2.7.15, and fail weirdly with 3.6, but not due to this change.