Limit Replacements Option Support#190
Open
KyleJamesWalker wants to merge 1 commit intoperitus:masterfrom
Open
Conversation
2b76b2e to
b2febae
Compare
b2febae to
d944ac9
Compare
Author
|
@peritus do you still maintain/update this library? I've noticed there isn't any recent activity, and honestly not sure if this is something you might even want to be part of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to use bumpversion for non-python files, the search functionality is too limited. When loading from the config parser, the values strip leading whitespace on newlines. This made it so it wouldn't match what was being searched, so instead, it seemed easier to just limit the amount of replaces in the file (in my use case).
My issue was a package-lock.json for a JS library:
Searching for
"version": "2.2.1",would capture theansi-stylesblock, and trying to do a multiline string would strip the whitespace before"version"so it wouldn't match correctly.Another possible direction would be to allow
\nvalues in the ConfigParser, by default when it sees\n, it converts it to\\n.bumpversioncould search and replace for escapped new lines, and replace them.Please let me know if you have another solution for this.
Note: I updated the tox file to get this working with newer python 3 versions, I'm not 100% sure if all those changes are good or desired.