Open
Conversation
tjanez
reviewed
May 14, 2020
tjanez
left a comment
tjanez
left a comment
There was a problem hiding this comment.
I would also suggest updating the "
ekohl
suggested changes
May 14, 2020
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
Should all code be removed as well? At least the tests are failing now.
3 tasks
Author
|
@ekohl -- we can certainly do that, FWIW I'm not a maintainer on this project, but I can include it in the PR if you are able to merge? |
|
Looking at my review icon (which is gray rather than green) I think I'm unable to. |
|
I think we could ask @peritus to review and merge this branch after it's ready. |
Owner
|
Sure. Can do that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.