Mips fix data memory view #113
Open
Annotations
8 warnings
|
|
|
src/gui_egui/components/wire.rs#L76
warning: this `map_or` can be simplified
--> src/gui_egui/components/wire.rs:76:25
|
76 | let is_active = simulator
| _________________________^
77 | | .as_ref()
78 | | .map_or(false, |sim| sim.is_active(&self.input.id));
| |_______________________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
help: use is_some_and instead
|
78 - .map_or(false, |sim| sim.is_active(&self.input.id));
78 + .is_some_and(|sim| sim.is_active(&self.input.id));
|
|
|
src/gui_egui/components/mux.rs#L25
warning: this `map_or` can be simplified
--> src/gui_egui/components/mux.rs:25:25
|
25 | let is_active = simulator
| _________________________^
26 | | .as_ref()
27 | | .map_or(false, |sim| sim.is_active(&self.id));
| |_________________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
help: use is_some_and instead
|
27 - .map_or(false, |sim| sim.is_active(&self.id));
27 + .is_some_and(|sim| sim.is_active(&self.id));
|
|
|
src/gui_egui/components/constant.rs#L26
warning: this `map_or` can be simplified
--> src/gui_egui/components/constant.rs:26:25
|
26 | let is_active = _simulator.map_or(false, |sim| sim.is_active(&self.id));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
= note: `#[warn(clippy::unnecessary_map_or)]` on by default
help: use is_some_and instead
|
26 - let is_active = _simulator.map_or(false, |sim| sim.is_active(&self.id));
26 + let is_active = _simulator.is_some_and(|sim| sim.is_active(&self.id));
|
|
|
src/components/mem.rs#L151
warning: manual implementation of `.is_multiple_of()`
--> src/components/mem.rs:151:10
|
151 | ((addr % size != 0) as SignalUnsigned).into()
| ^^^^^^^^^^^^^^^^^^ help: replace with: `!addr.is_multiple_of(size)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of
= note: `#[warn(clippy::manual_is_multiple_of)]` on by default
|
|
src/simulator.rs#L151
warning: called `is_some()` after searching an `Iterator` with `find`
--> src/simulator.rs:151:22
|
151 | .find(|node| node.get_id_ports().0 == seq_node_inputs.id)
| ______________________^
152 | | .is_some()
| |______________________________^ help: consider using: `any(|node| node.get_id_ports().0 == seq_node_inputs.id)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some
= note: `#[warn(clippy::search_is_some)]` on by default
|
|
|
|
|
The logs for this run have expired and are no longer available.
Loading