Refactor websockets dependencies: move the optional dependency to extras and unite imports#51
Refactor websockets dependencies: move the optional dependency to extras and unite imports#51orweis merged 3 commits intopermitio:masterfrom mberdyshev:reformat-optional-dependency
Conversation
…ras and unite imports
|
|
|
@orweis @danyi1212 Do you have time to take a look at it and review the code? |
izzywdev
left a comment
izzywdev
left a comment
There was a problem hiding this comment.
@mberdyshev I think the new build workflow is starting now with python 3.9 and on, try to pull from the last commit and run again.
izzywdev
left a comment
izzywdev
left a comment
There was a problem hiding this comment.
@mberdyshev thanks for this, I added my comments, and am happy to help with anything needed.
izzywdev
left a comment
izzywdev
left a comment
There was a problem hiding this comment.
@mberdyshev This looks good to me know. Thank you!
Support latest versions for tests.
|
@orweis, hello! Do you have time now for the code review? |
|
I believe @iwphonedo is on the case. |
|
@iwphonedo has already approved this PR. However, GitHub writes that merging is blocked because "At least 1 approving review is required by reviewers with write access". |
There was a problem hiding this comment.
Approved - @mberdyshev once you're ready you can merge / ask me to merge.
Thank you for your contribution.
@gemanor @danielbass37 - let's offer the man some Permit Swag as thank you
|
@orweis I have no available option to merge this PR, so you are welcome to do it. |
Congratulations - it's merged 😇 |
|
Thank you! Is it possible to make a new PyPI release? |
|
|
Great! Thank you a lot! |
4 participants
No description provided.