feat: Add PromQL expression validation with Perses variable support - #53
Merged
Conversation
Member
Author
|
@heliapb @saswatamcode Looking for some feedback, PTAL when you get a chance |
heliapb
reviewed
Jul 28, 2026
Member
|
other than that LGTM |
Add Validaite/ValidateWithVars for round-trip PromQL syntax checks (with Perses dashboard variable substitution). EqualRegexp/ NotEqualRegexp compile regex and panic on invalid patterns. Signed-off-by: Jayapriya Pai <janantha@redhat.com>
saswatamcode
approved these changes
Jul 28, 2026
saswatamcode
left a comment
saswatamcode
left a comment
Member
There was a problem hiding this comment.
Thanks! Looks like this won't break API too :)
slashpai
changed the title
heliapb
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add PromQL expression validation