Skip to content

Conversation

@shahrokni
Copy link
Contributor

Description πŸ–ŠοΈ

This change will add the extract fields transform definition to cue.

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.
  • E2E tests are stable and unlikely to be flaky.
    See e2e docs for more details. Common issues include:
    • Is the data inconsistent? You need to mock API requests.
    • Does the time change? You need to use consistent time values or mock time utilities.
    • Does it have loading states? You need to wait for loading to complete.

Signed-off-by: Mahmoud Shahrokni <seyedmahmoud.shahrokni@amadeus.com>
Copy link
Contributor

@jgbernalp jgbernalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, But I'll let @AntoineThebaud to also check

@jgbernalp
Copy link
Contributor

@shahrokni are there any test we can make for this changes?

@shahrokni
Copy link
Contributor Author

@shahrokni are there any test we can make for this changes?

I am not sure how we could only test the cue schema change. Is there any way that I am not aware of?

@AntoineThebaud
Copy link
Contributor

@shahrokni are there any test we can make for this changes?

I am not sure how we could only test the cue schema change. Is there any way that I am not aware of?

yes we have a basic testing framework in place for these common CUE definitions, see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants