fix: Adjust the PostgresConfig JSON/YAML tags to snake_case - #53
Merged
ibakshay merged 1 commit intoJul 13, 2026
Merged
Conversation
…s, connect_timeout, prepare_threshold, ssl_mode) matching the CUE schema in sql_patch.cue Signed-off-by: ZPascal <pascal.zimmermann@theiotstudio.com>
8 tasks
Contributor
Author
There was a problem hiding this comment.
Pull request overview
This PR aligns the PostgresConfig JSON/YAML field names with the CUE schema (sql_patch.cue) by switching selected fields from camelCase to snake_case, and updates unit tests accordingly.
Changes:
- Update
PostgresConfigstruct tags to snake_case (max_conns,connect_timeout,prepare_threshold,ssl_mode). - Update JSON/YAML unmarshalling tests to use the new snake_case keys.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| go/datasource/proxy/sql/sql.go | Switch Postgres config serialization tags to snake_case to match the CUE schema. |
| go/datasource/proxy/sql/sql_test.go | Update test fixtures to use snake_case keys for Postgres config JSON/YAML. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
I don't understand these changes as they are not aligned and are not compliant with the case choice of all resources in Perses. CamelCase is the case of all resources in Perses. The only exception is the Perses configuration. This PR needs to be reverted |
Member
|
and the cuelang file needs to be patched. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: perses/plugins#542