[ENHANCEMENT] Preserve unknown fields at panel spec and display level - #60
Closed
nicolastakashi wants to merge 1 commit into
Closed
[ENHANCEMENT] Preserve unknown fields at panel spec and display level#60nicolastakashi wants to merge 1 commit into
nicolastakashi wants to merge 1 commit into
Conversation
The panel spec (spec.panels[].spec) and its display object are closed schemas: any field not declared upstream is pruned or rejected at Kubernetes admission. This is inconsistent with plugin.spec, queries and variable specs, which already preserve unknown fields, and it prevents plugins and downstream tooling from attaching panel-level metadata when PersesDashboard resources are managed via the operator/GitOps. Add +kubebuilder:pruning:PreserveUnknownFields (without Schemaless, so the declared fields stay validated) on Panel.Spec and PanelSpec.Display, and regenerate the CUE. Refs: perses/perses-operator#435 Signed-off-by: Nicolas Takashi <nicolas.takashi@dash0.com>
Nexucis
reviewed
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The panel spec (spec.panels[].spec) and its display object are closed schemas: any field not declared upstream is pruned or rejected at Kubernetes admission. This is inconsistent with plugin.spec, queries and variable specs, which already preserve unknown fields, and it prevents plugins and downstream tooling from attaching panel-level metadata when PersesDashboard resources are managed via the operator/GitOps.
Add
+kubebuilder:pruning:PreserveUnknownFields(without Schemaless, so the declared fields stay validated) on Panel.Spec and PanelSpec.Display, and regenerate the CUE.Refs: perses/perses-operator#435