Skip to content

fix issue with 3d movie generation #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bgraedel merged 2 commits into from
May 5, 2025
Merged

fix issue with 3d movie generation #30

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d188f1
fix issue with 3d movie generation
bgraedel May 5, 2025
fe3e0f3
fix lint
bgraedel May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions arcos4py/plotting/_plotting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1408,10 +1408,10 @@
measurements = valid_cells[measurement_col].values
colors = cmap_all_cells(norm_all_cells(measurements))
if is_3d:
ax.scatter(
x=valid_cells[pos_cols[0]],
y=valid_cells[pos_cols[1]],
z=valid_cells[pos_cols[2]],
ax.scatter( # type: ignore[misc]

Check warning on line 1411 in arcos4py/plotting/_plotting.py

View check run for this annotation

Codecov / codecov/patch

arcos4py/plotting/_plotting.py#L1411 

Added line #L1411 was not covered by tests
valid_cells[pos_cols[0]],
valid_cells[pos_cols[1]],
valid_cells[pos_cols[2]],
s=all_cells_size,
c=colors,
alpha=all_cells_alpha,
Expand All @@ -1428,10 +1428,10 @@
)
elif not valid_cells.empty: # Fallback to fixed color
if is_3d:
ax.scatter(
x=valid_cells[pos_cols[0]],
y=valid_cells[pos_cols[1]],
z=valid_cells[pos_cols[2]],
ax.scatter( # type: ignore[misc]

Check warning on line 1431 in arcos4py/plotting/_plotting.py

View check run for this annotation

Codecov / codecov/patch

arcos4py/plotting/_plotting.py#L1431 

Added line #L1431 was not covered by tests
valid_cells[pos_cols[0]],
valid_cells[pos_cols[1]],
valid_cells[pos_cols[2]],
s=all_cells_size,
c=all_cells_fixed_color,
alpha=all_cells_alpha,
Expand Down Expand Up @@ -1461,10 +1461,10 @@
if not valid_cells.empty:
# FIX: Use explicit kwargs for scatter
if is_3d:
ax.scatter(
x=valid_cells[pos_cols[0]],
y=valid_cells[pos_cols[1]],
z=valid_cells[pos_cols[2]],
ax.scatter( # type: ignore[misc]

Check warning on line 1464 in arcos4py/plotting/_plotting.py

View check run for this annotation

Codecov / codecov/patch

arcos4py/plotting/_plotting.py#L1464 

Added line #L1464 was not covered by tests
valid_cells[pos_cols[0]],
valid_cells[pos_cols[1]],
valid_cells[pos_cols[2]],
s=bin_cell_size,
c=bin_cell_color,
alpha=bin_cell_alpha,
Expand Down Expand Up @@ -1505,10 +1505,10 @@
color = cmap_events(color_index)

if is_3d:
ax.scatter(
x=event_points[:, 0],
y=event_points[:, 1],
z=event_points[:, 2],
ax.scatter( # type: ignore[misc]

Check warning on line 1508 in arcos4py/plotting/_plotting.py

View check run for this annotation

Codecov / codecov/patch

arcos4py/plotting/_plotting.py#L1508 

Added line #L1508 was not covered by tests
event_points[:, 0],
event_points[:, 1],
event_points[:, 2],
s=event_cell_size,
c=[color], # Scatter expects color sequence
alpha=event_alpha,
Expand Down