Skip to content

PFX-WB-034: Add dashboard import runs table caption semantics #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peshay merged 2 commits into from
May 7, 2026
Merged

PFX-WB-034: Add dashboard import runs table caption semantics #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15e5584
PFX-WB-034 add hidden caption for dashboard import runs table
peshay May 7, 2026
a5c60c7
chore: retrigger CI for PR body update
peshay May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/portfolixir_web/live/dashboard_live.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,9 @@ defmodule PortfolixirWeb.DashboardLive do
<% else %>
<div class="app-shell-table-wrapper">
<table id="dashboard-import-runs-table">
<caption id="dashboard-import-runs-table-caption" class="app-shell-visually-hidden">
<%= gettext("Recent import runs with source, status, start time, and finish time.") %>
</caption>
<thead>
<tr>
<th scope="col"><%= gettext("Source") %></th>
Expand Down
7 changes: 7 additions & 0 deletions test/portfolixir_web/live/dashboard_live_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,13 @@ defmodule PortfolixirWeb.DashboardLiveTest do
{:ok, view, _html} = live(conn, "/")

assert has_element?(view, "#dashboard-recent-import-runs")

assert has_element?(
view,
"#dashboard-import-runs-table-caption.app-shell-visually-hidden",
"Recent import runs with source, status, start time, and finish time."
)

assert has_element?(view, "#dashboard-import-runs-link[href=\"/imports\"]")
assert has_element?(view, "#dashboard-import-run-row-#{run.id}")
assert has_element?(view, "#dashboard-import-run-row-#{run.id}", source.name)
Expand Down
Loading