-
Notifications
You must be signed in to change notification settings - Fork 51
Enhance 'purge' command with additional options #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dotpmm
wants to merge
9
commits into
dev
Choose a base branch
from
beta-pmm
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
193351f
Enhance 'purge' command with additional options
dotpmm 517e834
Refactor purge command for better readability
dotpmm 6c44c6b
Refactor purge function for cleaner syntax
dotpmm 38a5cfd
Enhance 'purge' command with additional options
dotpmm e4690d9
Fixed errors
dotpmm 8a9d9ca
Hopefully fixed all errors
dotpmm 3cfc144
Reverted .githooks
dotpmm df897e1
Add `/ban` command
dotpmm eea2e65
Revert "Add `/ban` command"
dotpmm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to use
anyhere instead ofsum?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used sum because we need to make sure exactly one of the three parameters is provided. any would only tell us if at least one is provided, which still allows two or three arguments at the same time(it just allows, we can find a workaround to select only one out of it, but then it defeats the purpose) . Using sum(x is not None β¦) lets us count how many were given and enforce the requirement cleanly.