Skip to content

Fix preview/browser proof reliability#19

Closed
peter-olom wants to merge 1 commit into
mainfrom
butler/manor-self-improvement-job-problem-a
Closed

Fix preview/browser proof reliability#19
peter-olom wants to merge 1 commit into
mainfrom
butler/manor-self-improvement-job-problem-a

Conversation

@peter-olom

Copy link
Copy Markdown
Owner

What changed

  • Bypass the runtime broker JSON parser for /routes/preview/* so preview POST/API request bodies stream through to the preview app instead of being consumed before proxying.
  • Add short retries around broker-to-Playwright browser proof control calls and replace raw transient fetch failed errors with an actionable readiness message.
  • Add focused regression coverage for preview POST proxy body handling and Playwright proof sidecar retry messaging.

Tests and build checks

  • node --check docker/runtime-broker/broker.mjs
  • node --check docker/runtime-broker/broker-browser.mjs
  • node --test docker/runtime-broker/broker-browser-annotation.test.mjs
  • In disposable snapshot preview: cd butler && npm ci
  • In disposable snapshot preview: cd butler && npm test -- test/server/runtime-broker-preview-isolation.test.ts && cd .. && node --test docker/runtime-broker/broker-browser-annotation.test.mjs (executed the Butler TS suite plus Docker browser regression)
  • In disposable snapshot preview: cd butler && npm run build

Proof / deployment note

  • Attempted manor-harness preview use start against a ready disposable preview on the current live stack; it still returned raw fetch failed, confirming the source blocker remains live until Manor is rebuilt/restarted with this PR. No live restart or deploy was performed.

Remaining risk

  • Requires rebuilding/restarting the Manor runtime-broker/playwright services for the broker changes to affect live proof capture.

Bypass the runtime broker JSON parser for preview proxy routes so POST/API request streams reach the preview app intact.

Retry transient Playwright proof sidecar fetch failures and surface a readiness hint instead of a raw fetch failed error.

Add focused regressions for preview POST proxying and browser proof sidecar retry behavior.

Copy link
Copy Markdown
Owner Author

Closing as superseded/stale: this work has been replaced by later merged Manor work.

@peter-olom peter-olom closed this Jun 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant