Fix preview/browser proof reliability#19
Closed
peter-olom wants to merge 1 commit into
Closed
Conversation
Bypass the runtime broker JSON parser for preview proxy routes so POST/API request streams reach the preview app intact. Retry transient Playwright proof sidecar fetch failures and surface a readiness hint instead of a raw fetch failed error. Add focused regressions for preview POST proxying and browser proof sidecar retry behavior.
Owner
Author
|
Closing as superseded/stale: this work has been replaced by later merged Manor work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
/routes/preview/*so preview POST/API request bodies stream through to the preview app instead of being consumed before proxying.fetch failederrors with an actionable readiness message.Tests and build checks
node --check docker/runtime-broker/broker.mjsnode --check docker/runtime-broker/broker-browser.mjsnode --test docker/runtime-broker/broker-browser-annotation.test.mjscd butler && npm cicd butler && npm test -- test/server/runtime-broker-preview-isolation.test.ts && cd .. && node --test docker/runtime-broker/broker-browser-annotation.test.mjs(executed the Butler TS suite plus Docker browser regression)cd butler && npm run buildProof / deployment note
manor-harness preview use startagainst a ready disposable preview on the current live stack; it still returned rawfetch failed, confirming the source blocker remains live until Manor is rebuilt/restarted with this PR. No live restart or deploy was performed.Remaining risk