Open
Conversation
📊 Size Comparison ReportBuild completed for commit 9e378e5 📦 Size ChangesUpdated automatically by the size test workflow |
peterbarker
force-pushed
the
pr/rewrite-test-size
branch
from
9a6c0f2 to
529a35d
Compare
Significantly simplifies the test_size workflow by replacing ~300 lines of manual build steps with a single call to size_compare_branches.py. Changes: - Removed matrix build strategy - Use single job with size_compare_branches.py parallelization (--parallel-copies 4) - Removed manual build logic for base and PR branches - Removed manual size comparison steps (pretty_diff_size.py) - Removed manual feature extraction steps (extract_features.py) - Use --all-vehicles to let size_compare_branches.py determine what to build - Removed artifact upload (output stays in job logs) Benefits: - Reduced workflow from ~330 lines to ~110 lines (-67%) - Single source of truth for size comparison logic - Easier to maintain - Same experience for CI and local development - Parallelization handled by size_compare_branches.py 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Add a step to fetch the base branch as 'upstream' remote before running size_compare_branches.py. This fixes the "Not a valid object name master" error by ensuring the base branch exists as a git reference. Changes: - Add git remote for base repository - Fetch base branch to upstream remote - Pass --master-branch upstream/<ref> instead of just <ref> 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
The --parallel-copies option requires rsync which is not available in the CI environment. Use --jobs instead to control build parallelization.
Add step to install rsync package which is required by size_compare_branches.py when using --parallel-copies. Restore --parallel-copies 4 with -j 2 for better parallelization across multiple source tree copies.
Keep rsync installed but don't use --parallel-copies. Use -j 8 for build parallelization instead.
Disable mount support by default to reduce flash usage.
Add a new step that captures the output from size_compare_branches.py and posts it as a formatted PR comment. The comment includes: - Size changes section with code block formatting - Feature changes section with readable ✅/❌ symbols for added/removed features - Auto-updates on each CI run - Clear headings and organization The comment is created on first run and updated on subsequent runs to avoid cluttering the PR with multiple bot comments.
peterbarker
force-pushed
the
pr/rewrite-test-size
branch
from
529a35d to
b2112d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.