CompatHelper: bump compat for Images to 0.25, (keep existing compat)#27
Conversation
d4ff7f8 to
230966e
Compare
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
=======================================
Coverage 44.33% 44.33%
=======================================
Files 8 8
Lines 1985 1985
=======================================
Hits 880 880
Misses 1105 1105 Continue to review full report at Codecov.
|
|
I haven't yet looked into the codes, but it's perhaps also doable to remove the Images dependency. |
|
I noticed an ancient usage The test coverage is only 44%, my best guess is that a large portion of functionalities in this package are broken already. So to upgrade this package I think we need some rewrite of the basic functions first. |
|
I agree the test coverage is rather woeful. I need to carefully step through each function removing ancient usage and improving the testing |
This pull request changes the compat entry for the
Imagespackage from0.9, 0.10, 0.11, 0.12, 0.13, 0.14, 0.15, 0.16, 0.17, 0.18, 0.19, 0.20, 0.21, 0.22, 0.23, 0.24to0.9, 0.10, 0.11, 0.12, 0.13, 0.14, 0.15, 0.16, 0.17, 0.18, 0.19, 0.20, 0.21, 0.22, 0.23, 0.24, 0.25.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.