Add an option to dbmate migrator to control if schema is auto dumped#37
Open
braindev wants to merge 1 commit intopeterldowns:mainfrom
Open
Add an option to dbmate migrator to control if schema is auto dumped#37braindev wants to merge 1 commit intopeterldowns:mainfrom
braindev wants to merge 1 commit intopeterldowns:mainfrom
Conversation
The default value for automatically dump schema is true but in a testing context this probably isn't desired. Small changes may show up in the schema which don't matter such as the architecture of the psql binary or a patch version difference.
Author
|
I'm not sure why auto-dumping the schema makes sense during testing. If that's the case then perhaps the change should just be to set auto-dump schema to false. |
|
It would be great if this could be merged |
|
@peterldowns Any chance this could get merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default value for automatically dump schema is true but in a testing context this probably isn't desired. Small changes may show up in the schema which don't matter such as the architecture of the psql binary or a patch version difference.