Adds a nix flake and support for it#46
Draft
MilitaoLucas wants to merge 12 commits intopeterspackman:mainfrom
Draft
Adds a nix flake and support for it#46MilitaoLucas wants to merge 12 commits intopeterspackman:mainfrom
MilitaoLucas wants to merge 12 commits intopeterspackman:mainfrom
Conversation
Contributor
Author
|
I think I must've messed something up. But to be fair I wasn't exactly expecting it would try to build on a draft PR. |
Owner
|
I'm all for this, I'll try and take some time and dig in to see if there's anything that could cause downstream pain or blocking issues, but in all likelihood I'll just merge this pretty quickly - thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I did some patches so my OS (NIxOS) can build OCC from source using Nix. Nix is a package manager for Unix, officially supporting Linux and MacOS. Its main objective is extreme reproducibility in builds, as it unsets all environment variables and everything that could make it "work in my machine".
For now there are some problems because Nix doesn't support -march=native and you have to do -march=x86_64v3 or your respective processor version. Those are mainly warnings. Those patches are also made because to ensure reproducibility Nix doesn't allow internet access during builds.
I created this as a draft because it would require changing the CMakeLists.txt for it to work, but the possibilities it opens for easier cross-compilation are nice. Basically this is mainly a proposal instead of a real PR. I do think it would be nice because it could potentially work for MacOS, Linux and Windows with MinGW.
I will open a new PR soon, after refactoring a bit, because I think I finalized everything I needed to implement OCC into NoSpherA2. I just thought I would make this one to see what do you think about making this available as an option.