Skip to content

Whatever you improved #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bedukkina wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Whatever you improved #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions improve_me.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import random, getopt, sys, os

# This line will only work in Python 2
print "This script is not perfect"
print "This script is not perfect, but slightly better"

# The following loop could be written in a single line with list comprehension
random_numbers = []
Expand All @@ -14,10 +14,10 @@
print random_numbers[i]

# This loop could be rewritten with enumerate
i = 0
for r in random_numbers:

for i,r in enumerate(random_numbers):
print(i, r)
i += 1

# This is not C
if(len(random_numbers)>5): print("Lots of random numbers here")
if(len(random_numbers)>5):
print("Lots of random numbers here")