Add root zone trust anchor validation to DNSSEC chain verification#11
Merged
Add root zone trust anchor validation to DNSSEC chain verification#11
Conversation
Copilot
AI
changed the title
[WIP] Fix missing root trust anchor validation
Add root zone trust anchor validation to DNSSEC chain verification
Feb 16, 2026
Co-authored-by: peterzen <5878500+peterzen@users.noreply.github.com>
Co-authored-by: peterzen <5878500+peterzen@users.noreply.github.com>
…omparison Co-authored-by: peterzen <5878500+peterzen@users.noreply.github.com>
Co-authored-by: peterzen <5878500+peterzen@users.noreply.github.com>
8e18783 to
e3c3114
Compare
…ing non-existent constructor Co-authored-by: peterzen <5878500+peterzen@users.noreply.github.com>
Contributor
Author
Fixed in commit 1c87a3f. The test was incorrectly trying to call |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation Complete: Root Trust Anchor Validation
Summary
Successfully implemented root trust anchor validation to fix a critical DNSSEC security vulnerability where the resolver was not validating the root zone DNSKEY against a trust anchor.
Changes Made
Security Impact
This fix prevents a critical attack vector where a misbehaving DNS server could spoof the entire DNS chain up to the root zone, which the resolver would previously accept as valid. Now the entire DNSSEC chain of trust is validated from the queried domain all the way to the root, ensuring full compliance with DNSSEC validation requirements per RFC 4033 and RFC 4034.
Code Quality
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.