Config file support instead of requiring environment variables. #5
Open
BrettSheleski wants to merge 4 commits into
Open
Config file support instead of requiring environment variables. #5BrettSheleski wants to merge 4 commits into
BrettSheleski wants to merge 4 commits into
Conversation
petkov
reviewed
Mar 10, 2018
| password: process.env.MQTT_PASS || '', | ||
| clientId: process.env.MQTT_CLIENT_ID || null | ||
| clientId: process.env.MQTT_CLIENT_ID || null, | ||
| protocol: process.env.MQTT_PROTOCOL || 'mqtt' |
Owner
There was a problem hiding this comment.
Do we really need to set protocol. I usually set it using host like mqtts://mqtt.com:123456. Also I don't like to have mqtt as default, this might be a security bridge. I think mqtts is better.
Collaborator
Author
There was a problem hiding this comment.
You need to set the protocol if the host is anything but null. Otherwise the mqtt library throws an exception.
Default to mqtts if you prefer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made these changes a while ago. I just thought I'd share.