ci(release): fetch Windows App Runtime before Inno Setup; version-aware extension packages#48
Closed
pexatar wants to merge 1 commit into
Closed
ci(release): fetch Windows App Runtime before Inno Setup; version-aware extension packages#48pexatar wants to merge 1 commit into
pexatar wants to merge 1 commit into
Conversation
… Setup The release workflow failed on every tag at "Build installer and portable ZIP": Installer/PassKey.iss bundles WindowsAppRuntimeInstall-x64.exe as a [Files] Source, but that binary is git-ignored (too large to commit) and CI never fetched it, so Inno Setup aborted with "Source file ... does not exist" on a fresh runner. Local builds worked only because the file existed on the dev box. build-installer.ps1 now ensures the redistributable is present before invoking Inno Setup, downloading it via Installer/Download-Runtime.ps1 (authoritative aka.ms URL pinned to WindowsAppSDK 1.8.260416003) when missing. Also make make-chrome-zip.ps1 / make-xpi.ps1 read the version from manifest.json instead of hardcoding "1.0.0", so the package filename matches the extension. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Release workflow (
.github/workflows/release.yml) failed on every tag at the Build installer and portable ZIP step.Installer/PassKey.issline 47 bundlesWindowsAppRuntimeInstall-x64.exeas a[Files]Source, but that binary is git-ignored (too large to commit) and CI never downloaded it. On a fresh runner Inno Setup aborts:Local builds worked only because the file already existed on the dev machine.
v2.0.0was the first tag to use this CI (added in #41); it failed and was released manually.Fix
scripts/build-installer.ps1— before invoking Inno Setup, ensure the redistributable is present; if missing, download it via the existingInstaller/Download-Runtime.ps1, which pins the authoritative aka.ms URL to the WindowsAppSDK package version in use (1.8.260416003). Verified the URL returns the real signed binary (MZPE header) and the version matchesMicrosoft.WindowsAppSDKinPassKey.Desktop.csproj.Minor
make-chrome-zip.ps1/make-xpi.ps1— readversionfrommanifest.json(currently1.0.1) instead of hardcoding1.0.0, so the package filename matches the extension. (These were previously untracked; the corrected versions are committed here.)Testing
https://aka.ms/windowsappsdk/1.8/1.8.260416003/windowsappruntimeinstall-x64.exeresolves to a realdownload.microsoft.combinary starting withMZ.1.0.1from their manifests.🤖 Generated with Claude Code