fix(security): harden browser IPC + extension consent/UX [v2.0]#52
Merged
Conversation
Cluster 6 — closes the 3 IPC vulnerabilities (external audit) and bundles the
browser-extension enhancements so the extension is re-published only once.
Security (SEC-01/02/03) — BrowserIpcService + IpcModels + 6x resw + extensions:
- SEC-01: mandatory ECDH, no plaintext fallback (error 'ecdh-session-required').
- SEC-02: session bound to the handshake clientId (no cross-client reuse).
- SEC-03: explicit user consent on password retrieval ("remember for this
session", reset on vault lock); consent + ECDH sessions cleared on lock.
- Hardening: unlock-vault rate-limit/lockout + cap on concurrent ECDH sessions.
Extension (Chrome + Firefox, 6 languages):
- T6.2 autofill success toast; T6.3 visible connection-status indicator.
- Consent moved off popup-open (get-all-credentials no longer prompts);
per-action request timeouts (consent/unlock) avoid false "not running".
- Fixed an IPC deadlock: the consent dialog read a WinUI element off the UI
thread (RPC_E_WRONG_THREAD) -> server hung; now captured via events.
Interim: SEC-03 consent is the stopgap; SEC-05 (process attestation) will
replace it frictionlessly (planned, Cluster 6.5).
Adds scripts/ipc-security-test.ps1 (named-pipe harness, checklist Fase A/E).
Build 0/0, tests 222/222, security harness all SECURE on a live build.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cluster 6 — Browser IPC security (SEC-01/02/03) + extension enhancements
Chiude le 3 vulnerabilità IPC dell'audit esterno e include gli enhancement estensione, così la ri-pubblicazione sugli store avverrà una sola volta (Cluster 8 / T8.5).
🔒 Security (SEC-01/02/03) —
BrowserIpcService.cs,IpcModels.cs, 6×Resources.resw, estensioniecdh-session-required.clientIddell'handshake → niente riuso cross-client anche se il session id trapela.unlock-vault+ cap sul numero di sessioni ECDH concorrenti.✨ Extension (Chrome + Firefox, 6 lingue)
get-all-credentialsnon chiede più nulla); timeout per-azione (consenso/sblocco) per evitare falsi "PassKey non è in esecuzione".RPC_E_WRONG_THREAD) → server IPC bloccato; ora lo stato della checkbox è catturato via eventi.🧪 Verifica
scripts/ipc-security-test.ps1(Fase A/E) eseguito su build live: SEC-01/02/03 + LOCK = SECURE, happy-path consenso→decrypt OK.⏭️ Follow-up
IpcConsentBodyAll.🤖 Generated with Claude Code