Update data structure logic in all files#84
Merged
ClaudiaGivan merged 1 commit intomainfrom Sep 23, 2025
Merged
Conversation
c03fa82 to
f19d38b
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the data structure properties used across all chart components to use more generic naming conventions. The changes standardize field names from domain-specific terms to generic ones, making the codebase more flexible and reusable.
- Updated property names from
leadTimetovalueandticketIdtosourceIdacross all chart components - Modified documentation and JSDoc comments to reflect the new property names
- Updated test data to use the new structure
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| test/testData/ScatterplotGraphExpectedOutput.js | Updated test data to use value and sourceId properties |
| src/graphs/scatterplot/SimpleScatterplotRenderer.js | Changed property references and documentation from leadTime/ticketId to value/sourceId |
| src/graphs/scatterplot/ScatterplotRenderer.js | Updated all chart rendering logic to use new property names |
| src/graphs/scatterplot/ScatterplotGraph.js | Modified data transformation logic to generate new property structure |
| src/graphs/moving-range/MovingRangeRenderer.js | Updated moving range chart to use new properties and removed debug logging |
| src/graphs/moving-range/MovingRangeGraph.js | Changed data processing to use value and sourceId properties |
| src/graphs/histogram/HistogramRenderer.js | Updated documentation to reflect new sourceId property |
| src/graphs/control-chart/ControlRenderer.js | Changed control chart rendering to use new property names |
| examples/sidebars.js | Updated form initialization to use sourceId |
| examples/example.js | Modified filtering logic to use value property |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.