Skip to content

fix: db guc set supports quoted param #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GabriellePoncey merged 2 commits into from
Jul 8, 2025
Merged

fix: db guc set supports quoted param #345

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02c13d0
fix: db guc set supports quoted params\n Adds an extra set of quotati…
Jul 1, 2025
c7c492e
fix: db guc set supports quoted params
Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cli/scripts/db.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import json
import util
import fire
import re

def create(db=None, User=None, Passwd=None, pg=None, spock=None, help=False):
"""
Expand Down Expand Up @@ -116,11 +117,15 @@ def guc_set(guc_name, guc_value):
nc = "./pgedge "
ncb = nc + "pgbin " + str(pg) + " "

cmd = f"ALTER SYSTEM SET {guc_name} = {guc_value}"
guc_value = re.sub(r'([\'\\])', r'\1\1', str(guc_value))
cmd = f"ALTER SYSTEM SET {guc_name} = '{guc_value}'"
Comment thread
jason-lynch marked this conversation as resolved.

rc1 = util.echo_cmd(ncb + '"psql -q -c \\"' + cmd + '\\" postgres"',False)
cmd = f"SELECT pg_reload_conf()"
rc2 = util.echo_cmd(ncb + '"psql -q -c \\"' + cmd + '\\" postgres"',False)

rcs = rc1 + rc2

if rcs == 0:
util.message(f"Set GUC {guc_name} to {guc_value}","info")
else:
Expand Down