Skip to content

pg1-host issue resolved #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
moizpgedge merged 2 commits into from
Jul 8, 2025
Merged

pg1-host issue resolved #349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
584e593
pg1-host issue resolved
moizpgedge Jul 2, 2025
87a36a5
pg1-host remove from install-backrest module
moizpgedge Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/backrest/backrest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@ def fetch_config():
"repo1-retention-full-type", "repo1-path", "repo1-host-user",
"repo1-host", "repo1-cipher-type", "log-level-console",
"repo1-type", "process-max", "compress-level", "pg1-path",
"pg1-user", "pg1-database", "db-socket-path", "pg1-port",
"pg1-host"
"pg1-user", "pg1-database", "db-socket-path", "pg1-port"

@jason-lynch jason-lynch Jul 3, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Should we also remove this line?

cli/src/backrest/install-backrest.py

Line 61 in 584e593

"pg1-host": "127.0.0.1",

Otherwise, it looks like we'll have an unused pg1-host variable (with a bad value) in the SQLite database.

@moizpgedge moizpgedge Jul 8, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it was mentioned in the ticket to remove it

]
for param in params:
config[param] = util.get_value("BACKUP", param)
Expand Down
1 change: 0 additions & 1 deletion src/backrest/install-backrest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ def configure_backup_settings():
"pg1-path": "xx",
"pg1-user": "xx",
"pg1-port": "5432",
"pg1-host": "127.0.0.1",
"db-socket-path": "/tmp",
"global:archive-push": {
"compress-level": "3"
Expand Down