add validation to um install for spock5 upgrade - #356
Merged
Conversation
moizpgedge
commented
Jul 21, 2025
Contributor
- Auto‑check helper – runs all the upgrade checks for you, no manual steps.
- Already on Spock 5? – if it finds Spock 5, it stops right away and ends successfully.
- Big warning banner – shows a clear message that the upgrade will cause downtime.
- Finds your versions – reads a local SQLite file to see which Postgres and Spock versions you have.
- Safe match test – makes sure those versions work together; if they don’t, it quits with an error.
Upgrade-spock function hide
mmols
reviewed
Jul 21, 2025
mmols
reviewed
Jul 21, 2025
mmols
reviewed
Jul 21, 2025
mmols
reviewed
Jul 22, 2025
mmols
approved these changes
Jul 23, 2025
mmols
added a commit
that referenced
this pull request
Aug 6, 2025
* major spock version upgrade command (draft) * successfully upgraded to spock5 using um upgrade-spock * spock 5 upgrade support * Update um.py Upgrade-spock function hide * code refactored * additional test case added for spock 5 upgrade comp check * additional test case added for spock 5 upgrade comp check * additional test case added for spock 5 upgrade comp check * warning banner removed from case 3 * final adjustment to logging output --------- Co-authored-by: Matthew Mols <matt@pgedge.com>
mmols
added a commit
that referenced
this pull request
Aug 6, 2025
* major spock version upgrade command (draft) * successfully upgraded to spock5 using um upgrade-spock * spock 5 upgrade support * Update um.py Upgrade-spock function hide * code refactored * additional test case added for spock 5 upgrade comp check * additional test case added for spock 5 upgrade comp check * additional test case added for spock 5 upgrade comp check * warning banner removed from case 3 * final adjustment to logging output --------- Co-authored-by: Matthew Mols <matt@pgedge.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.