Skip to content

Set CXX standard based on PQXX version#328

Open
bradfordboyle wants to merge 1 commit into
pgRouting:developfrom
bradfordboyle:fix-pqxx-cxx-standard
Open

Set CXX standard based on PQXX version#328
bradfordboyle wants to merge 1 commit into
pgRouting:developfrom
bradfordboyle:fix-pqxx-cxx-standard

Conversation

@bradfordboyle
Copy link
Copy Markdown

@bradfordboyle bradfordboyle commented May 13, 2026

Summary by CodeRabbit

  • Chores
    • Updated build system to support modern C++ language standards based on library version detection, enabling improved compiler compatibility and support for newer features across different environments.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 201bffb4-bd69-4441-8a90-937ed4369b3f

📥 Commits

Reviewing files that changed from the base of the PR and between ecfcb16 and 7622f12.

📒 Files selected for processing (1)
  • CMakeLists.txt

Walkthrough

The build configuration now selects the C++ language standard dynamically based on the detected libpqxx version. For libpqxx 8.0.0 and later, the project uses C++20; for 7.0.0 and later, C++17; and for older versions, C++14 with a backward-compatibility macro defined.

Changes

Build Configuration Update

Layer / File(s) Summary
C++20 support for libpqxx 8.0.0+
CMakeLists.txt
CMake build configuration adds explicit version check for PQXX_VERSION >= 8.0.0 to select C++20 standard, maintaining existing C++17 (for 7.0.0+) and C++14 (fallback) conditionals.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A rabbit hops through build-time code,
C++ standards on the road,
Twenty when libpqxx is eight,
Seventeen for those past seven's gate,
Backward compat, old and new—
Build scripts hopping straight through! 🐰

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: setting the C++ standard selection based on detected PQXX version across different version branches.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant