Fix deparse typmod fallback to return recoverable error instead of assert (issue #330)#331
Open
LucaCappelletti94 wants to merge 1 commit intopganalyze:17-latestfrom
Open
Fix deparse typmod fallback to return recoverable error instead of assert (issue #330)#331LucaCappelletti94 wants to merge 1 commit intopganalyze:17-latestfrom
LucaCappelletti94 wants to merge 1 commit intopganalyze:17-latestfrom
Conversation
Replace Assert(false) in deparseTypeName typmod fallback with elog(ERROR), and add deparse regression cases that require parse success and deparse error for enum typmod constructs (issue pganalyze#330).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a deparser crash path reported in #330 by replacing a hard
Assert(false)indeparseTypeNamewith a recoverableelog(ERROR, ...).With this change,
pg_query_deparse_protobuf*now returns a normalPgQueryErrorfor unsupported typmod node kinds, instead of:DEBUG=1builds, or