Compute SHA1 shard key from raw digest bytes#1239
Closed
crodas wants to merge 1 commit into
Closed
Conversation
The SHA1 sharding hash formatted the full 20-byte digest as a hex string, then parsed the last 8 hex characters back into an integer on every call. That allocated a string and ran a radix parse to recover bytes already sitting in the digest. Read the last four bytes directly and assemble the key with u32::from_be_bytes. The last 8 hex characters map to bytes 16 through 19, so the shard assignment is unchanged; only the work to extract it goes away. This also drops the unwrap on the parse.
|
|
Contributor
Author
|
This is already merged as part of #1240 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SHA1 sharding hash formatted the full 20-byte digest as a hex string, then parsed the last 8 hex characters back into an integer on every call. That allocated a string and ran a radix parse to recover bytes already sitting in the digest.
Read the last four bytes directly and assemble the key with u32::from_be_bytes. The last 8 hex characters map to bytes 16 through 19, so the shard assignment is unchanged; only the work to extract it goes away. This also drops the unwrap on the parse.