Skip to content

feat: add process name to 2pc transaction ID + cleanup abandoned#1248

Open
levkk wants to merge 5 commits into
mainfrom
levkk-pod-transaction-name
Open

feat: add process name to 2pc transaction ID + cleanup abandoned#1248
levkk wants to merge 5 commits into
mainfrom
levkk-pod-transaction-name

Conversation

@levkk

@levkk levkk commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Globally unique transaction ID

Without hopefully going over the 200 bytes limit.

Example:

__pgdog_2pc_pgdog-node-1_1231424234

The last part (the number) can be up to 20 chars long (usize::MAX), so I'm optimistic people don't name their nodes something 150 characters long, but I may be proven wrong.

Cleanup abandoned

Without durability, 2pc transactions can be left unfinished on PgDog crash/dirty shutdown. Leaving those around is bad: they can block vacuum.

TODO: need to add tests.

@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

@levkk levkk changed the title feat: add process name to 2pc transaction ID feat: add process name to 2pc transaction ID + cleanup abandoned Jul 22, 2026
@levkk
levkk requested review from meskill and sgrif July 22, 2026 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant