feat: add process name to 2pc transaction ID + cleanup abandoned#1248
Open
levkk wants to merge 5 commits into
Open
feat: add process name to 2pc transaction ID + cleanup abandoned#1248levkk wants to merge 5 commits into
levkk wants to merge 5 commits into
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Globally unique transaction ID
Without hopefully going over the 200 bytes limit.
Example:
The last part (the number) can be up to 20 chars long (
usize::MAX), so I'm optimistic people don't name their nodes something 150 characters long, but I may be proven wrong.Cleanup abandoned
Without durability, 2pc transactions can be left unfinished on PgDog crash/dirty shutdown. Leaving those around is bad: they can block vacuum.
TODO: need to add tests.