feat: support readable time values in config - #1273
Open
l4l wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human-readable durations in config
Time settings now accept strings like
"1h5m15s"alongside plain numbers, soban_timeout = 300000can be written asban_timeout = "5m".Motivation: make these value readable by mere mortals.
The spaces can be put anywhere, so " 1 h 2 m " also should work. The plain numbers still work and handled as before, this is an extension for params view.
New
pgdog-config/src/duration.rsparsesms/s/m/h/dvia serde(with=..) for all time fields.PGDOG_*env vars supports the same syntax.Limitations:
SET ban_timeout TO '5m';