Configurable sampling interval and call-stack tracing depth#80
Open
janpapenbrock wants to merge 1 commit intophacility:masterfrom
Open
Configurable sampling interval and call-stack tracing depth#80janpapenbrock wants to merge 1 commit intophacility:masterfrom
janpapenbrock wants to merge 1 commit intophacility:masterfrom
Conversation
Slach
added a commit
to Slach/xhprof
that referenced
this pull request
Apr 29, 2018
see humanmade#2 and phacility#80 Signed-off-by: Slach <bloodjazman@gmail.com>
remicollet
pushed a commit
to remicollet/xhprof
that referenced
this pull request
Jul 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is basically just a rebase of #34. All implementation credit goes to @turchanov.
Reason for this rebase: The original PR contained some additional, unrelated changes.
This PR adds two options to configure
xhprof_sample_*functions behavior:xhprof.sampling_interval- Configure the sampling interval in microseconds, i.e. the time between two samples being taken. Defaults to the current hard-coded default of 100 miliseconds (=100,000 microseconds).xhprof.sampling_depth- Configure the call stack depth being sampled, i.e. when set to 10, only the 10 deepest method calls are recorded. Defaults to INT_MAX.Both additions are great for in-depth performance analysis of requests with short response times, where the original sampling interval of 100 miliseconds is not useful at all.
Exemplary usage in the wild: