T27 full db support - #29
Merged
Merged
Conversation
Assisted-by: Claude Code
Assisted-by: Claude Code
Assisted-by: Claude Code
Assisted-by: Claude Code
Assisted-by: Claude Code
Assisted-by: Claude Code
Assisted-by: Claude Code
Code Metrics Report
Details | | master (18ab999) | #29 (b60f738) | +/- |
|---------------------|------------------|---------------|------|
| Coverage | 100.0% | 100.0% | 0.0% |
| Files | 52 | 53 | +1 |
| Lines | 967 | 994 | +27 |
+ | Covered | 967 | 994 | +27 |
- | Test Execution Time | 2s | 3s | +1s |Code coverage of files in pull request scope (100.0% → 100.0%)
Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Phalcon\Talon\Database\Dialect, an enum resolving a PDO connection toMysql,Pgsql, orSqlite, with per-dialect identifier quoting.DatabaseTrait::getDialect(), returning the connection'sDialect. Use it to choose SQL syntax; usegetDriver()to tell MariaDB from MySQL.Connection::select()now matches a NULL criterion withIS NULLinstead ofcol = :col, which matched nothing.assertNotInDatabase('t', ['x' => null])previously passed regardless of the data.Connection::select()now quotes table and column identifiers per dialect, so reserved words such asorderandkeywork.DATA_POSTGRES_SCHEMAis now applied to the connection asSET search_path. It was previously read into the options and ignored.Thanks