Skip to content

T27 full db support - #29

Merged
niden merged 7 commits into
masterfrom
T27-full-db-support
Jul 30, 2026
Merged

T27 full db support#29
niden merged 7 commits into
masterfrom
T27-full-db-support

Conversation

@niden

@niden niden commented Jul 30, 2026

Copy link
Copy Markdown
Member

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Phalcon\Talon\Database\Dialect, an enum resolving a PDO connection to Mysql, Pgsql, or Sqlite, with per-dialect identifier quoting.

DatabaseTrait::getDialect(), returning the connection's Dialect. Use it to choose SQL syntax; use getDriver() to tell MariaDB from MySQL.

Connection::select() now matches a NULL criterion with IS NULL instead of col = :col, which matched nothing. assertNotInDatabase('t', ['x' => null]) previously passed regardless of the data.

Connection::select() now quotes table and column identifiers per dialect, so reserved words such as order and key work.

DATA_POSTGRES_SCHEMA is now applied to the connection as SET search_path. It was previously read into the options and ignored.

Thanks

@niden
niden requested a review from Jeckerson July 30, 2026 19:44
@niden niden self-assigned this Jul 30, 2026
@niden niden added the new feature request Planned Feature or New Feature Request label Jul 30, 2026
@github-actions

Copy link
Copy Markdown

Code Metrics Report

master (18ab999) #29 (b60f738) +/-
Coverage 100.0% 100.0% 0.0%
Test Execution Time 2s 3s +1s
Details
  |                     | master (18ab999) | #29 (b60f738) | +/-  |
  |---------------------|------------------|---------------|------|
  | Coverage            |           100.0% |        100.0% | 0.0% |
  |   Files             |               52 |            53 |   +1 |
  |   Lines             |              967 |           994 |  +27 |
+ |   Covered           |              967 |           994 |  +27 |
- | Test Execution Time |               2s |            3s |  +1s |

Code coverage of files in pull request scope (100.0% → 100.0%)

Files Coverage +/- Status
src/Database/Connection.php 100.0% 0.0% modified
src/Database/Dialect.php 100.0% +100.0% added
src/Traits/DatabaseTrait.php 100.0% 0.0% modified

Reported by octocov

@niden
niden merged commit ca1a825 into master Jul 30, 2026
22 checks passed
@niden
niden deleted the T27-full-db-support branch July 30, 2026 19:51
@niden niden mentioned this pull request Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature request Planned Feature or New Feature Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant