Skip to content
This repository was archived by the owner on Oct 20, 2024. It is now read-only.

Material 3 Design#100

Open
SeineEloquenz wants to merge 34 commits intophantomate:mainfrom
SeineEloquenz:material_3
Open

Material 3 Design#100
SeineEloquenz wants to merge 34 commits intophantomate:mainfrom
SeineEloquenz:material_3

Conversation

@SeineEloquenz
Copy link

@SeineEloquenz SeineEloquenz commented Aug 6, 2024

Hi, first let me say thanks for providing this great app!

With this pull request I want to propose updating the app to use Material Design 3 so it fits in on modern Android devices.

@SeineEloquenz SeineEloquenz marked this pull request as ready for review August 6, 2024 10:05
@SeineEloquenz
Copy link
Author

SeineEloquenz commented Aug 6, 2024

Here are some screenshots of the changes with dynamic colors from my phone enabled:

Screenshots

Screenshot_20240806-120755
Screenshot_20240806-120835
Screenshot_20240806-120841
Screenshot_20240806-120848
Screenshot_20240806-120856
Screenshot_20240806-120912
Screenshot_20240806-120918
Screenshot_20240806-120937

@phantomate
Copy link
Owner

Hi, thank you for your effort and work. I see that there is now an addidtional toggle in the settings. Does this mean, that this can be turned off and on?
The thing is, that I also release this on the Apple Store for iOS and I don't want that the App looks too much like Android.

@SeineEloquenz
Copy link
Author

SeineEloquenz commented Aug 7, 2024

The additional toggle is to turn off dynamic colors. Then the previous behavior of the selectable accent colors is restored. The toggle does not restore the previous material design 2 theme however.
But according to the Flutter documentation, Material 2 will be removed sometime in the future anyhow.

I don't own an Apple device sadly and can therefore not test the changes there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants