Skip to content

Devel#72

Merged
mstackhouse merged 11 commits intomainfrom
devel
May 9, 2025
Merged

Devel#72
mstackhouse merged 11 commits intomainfrom
devel

Conversation

@nicholas-masel
Copy link
Copy Markdown
Collaborator

@nicholas-masel nicholas-masel commented Apr 2, 2025

Thank you for your Pull Request! Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests
  • Update to all relevant roxygen headers and examples.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • Build site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the reference page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue so that it closes after successful merging.
  • Address all merge conflicts and resolve appropriately.
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

nmasel and others added 11 commits October 9, 2024 13:39
* initial updates

* update documentation and snapshots

* Update cran-comments.md

---------

Co-authored-by: Michael Stackhouse <michaelstackhouse0614@gmail.com>
Closes #61: fixed linter config and findings
…el-of-hierarchy-throws-error

Closes #66: remove nulls before setting autos
@nicholas-masel nicholas-masel marked this pull request as ready for review May 2, 2025 16:34
@nicholas-masel nicholas-masel requested a review from mstackhouse May 2, 2025 16:34
@mstackhouse mstackhouse merged commit fa420cb into main May 9, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants