move paths to an environment w/in envsetup#80
Merged
nicholas-masel merged 5 commits intodevelfrom Jul 30, 2025
Merged
Conversation
Contributor
|
Does the environment here live in the package namespace? |
Collaborator
Author
|
Yep
…On Wed, Jul 9, 2025, 4:53 PM Michael Stackhouse ***@***.***> wrote:
*mstackhouse* left a comment (pharmaverse/envsetup#80)
<#80 (comment)>
Does the environment here live in the package namespace?
—
Reply to this email directly, view it on GitHub
<#80 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOSKU73E6R2RQJLQU6E4PPL3HV6L5AVCNFSM6AAAAACBEQ2D36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTANJTHE3TAOBXG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Collaborator
Author
|
We could store all of the path objects in global too. I think the only benefit to putting this within the environment of the package is so they are not overwritten. And so we can have the read and write functions look directly here for these path objects. |
Collaborator
Author
|
@mstackhouse I'll merge into dev and you can do the review of the PR to main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial draft to move paths to an environment. I'll update the rest of the package (vignettes, etc.) after we agree this is the direction we want to go.