Cavrois fix for UI process order#1344
Open
AlexisCnockaert wants to merge 1 commit intopharo-spec:Pharo14from
Open
Cavrois fix for UI process order#1344AlexisCnockaert wants to merge 1 commit intopharo-spec:Pharo14from
AlexisCnockaert wants to merge 1 commit intopharo-spec:Pharo14from
Conversation
I did an investigation and the `applyWorldResize` was looking at existing windows without waiting the UI process execution, meaning it was looking for iceberg windows (if present in a profile) despite Iceberg not being initialized. It could also break other thing, having race conditions or any other thing, so I fixed it using the UIManager defer: . Fixes #19149
Ducasse
reviewed
Mar 2, 2026
| (Delay forMilliseconds: 2) wait ] ] forkAt: | ||
| Processor userBackgroundPriority. | ||
| self handleWindowDrag: aClient at: aClient position. | ||
| (Delay forMilliseconds: 2) wait ] ] forkAt: Processor userBackgroundPriority. |
Contributor
There was a problem hiding this comment.
can you ask pablo or guille because I'm nervous to have more processes around.
The defer: is good because it is in the UI cycle.
Contributor
Author
There was a problem hiding this comment.
Ok I will ask someone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did an investigation and the
applyWorldResizewas looking at existing windows without waiting the UI process execution, meaning it was looking for iceberg windows (if present in a profile) despite Iceberg not being initialized. It could also break other thing, having race conditions or any other thing, so I fixed it using the UIManager defer: .Fixes #19149