fix(precons): replace native type filter and handle catalog load failures

[carlh7777]

Summary

Fixes two user-facing issues in the Preconstructed Decks modal on Windows:

1. Replaces the native deck type filter with the shared MenuSelect component to eliminate a rendering issue where a stray "All (0)" option could appear outside the dropdown.
2. Improves deck catalog loading failure handling by surfacing a dedicated error state when decks.json cannot be loaded, preventing the UI from remaining indefinitely stuck on "Loading deck catalog...".

These changes improve consistency with the rest of the application and provide clearer feedback when deck data is unavailable.

Implementation Method (Required)

How was the engine/parser logic in this PR produced? Check exactly one:

• Produced via the /engine-implementer pipeline (plan → review-plan → implement → review-impl → commit)
• Not /engine-implementer — explain why below

Reason

This is a frontend-only UI and UX improvement.

• Replaced the native SelectField implementation in PreconDeckModal with the existing shared MenuSelect component used elsewhere in the application.

• Extended useDecks() to expose explicit loading and loadError states.

• Updated modal rendering logic to distinguish between:

  • Catalog loading in progress
  • Successful catalog load
  • Catalog load failure

No gameplay systems, engine behavior, parser logic, rules processing, targeting, effect resolution, or networking logic were modified.

Note

Any change to crates/engine/ game logic — parser, effects, resolver, targeting, or rules behavior — is expected to go through /engine-implementer.

This PR only affects frontend presentation and error handling.

CR References

None.

The change is limited to UI presentation and client-side loading state management. No game rules, deck validation logic, or engine functionality were modified.

User Impact

Before

• Windows users could observe a native select rendering artifact where a stray option appeared outside the dropdown.
• If decks.json failed to load, the modal remained indefinitely in a loading state with no indication that an error had occurred.

After

• The type filter uses the shared MenuSelect component, providing consistent cross-platform behavior.
• Catalog loading failures are surfaced with a clear error message and actionable feedback instead of an endless loading indicator.

Verification

Automated

pnpm exec vitest run \
  src/components/menu/__tests__/MyDecks.test.tsx \
  src/pages/__tests__/GameSetupPage.test.tsx

Result: ✅ Pass

Manual Testing

• Open My Decks → Preconstructed.
• Verify the type filter renders via MenuSelect.
• Confirm no floating or detached options appear on Windows.
• Simulate a missing or failed decks.json request.
• Verify the modal displays an explicit error state instead of remaining on "Loading deck catalog..." indefinitely.
• Verify normal catalog loading behavior remains unchanged.

Screenshots

Before

After

[gemini-code-assist]

Code Review

This pull request updates the useDecks hook to return loading and error states, replaces the SelectField with MenuSelect in PreconDeckModal, and adds corresponding loading and error UI states. The review feedback recommends refactoring the boolean flags (loading and loadError) to a single status enum ('loading' | 'success' | 'error') across the hook, components, and tests to comply with the repository's style guide rule against boolean fields (Rule R2).

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[matthewevans]

This is a frontend change (precons UI: native type filter replacement + catalog load-failure handling across client/src components/hooks/i18n/pages), which the maintainer reviews directly — UI behavior + the i18n key changes need a browser check and locale-parity verification the automated review loop can't do. Flagging for maintainer review; no engine/rules concerns from my side.