fix(client): land undo button above phase HUD#3693
Open
kiannidev wants to merge 3 commits into
Open
Conversation
The undo control sat at the bottom of the lands column (z-10) while the player HUD band uses z-20, blocking clicks. Render it as a z-30 overlay anchored to the middle row instead. Fixes phase-rs#3276 Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Member
|
VERDICT: defer-frontend This is a small frontend-only positioning change. I don’t see an engine/rules concern in the diff: it moves the existing land-column extra control into a I’m leaving this for maintainer visual review rather than auto-enqueueing, because this is UI polish and the PR currently has only a manual test note, not a screenshot/screen recording of the overlapped phase-HUD case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Fixes #3276
Made with Cursor