Add Rampant Frogantua lost-player pump regression#3742
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds a new unit test dynamic_pt_lost_game_player_count_scales_past_one_player in crates/engine/src/game/layers.rs to verify that dynamic power and toughness scaling based on the count of players who have lost the game works correctly when multiple players are eliminated. It also imports PlayerFilter to support this test. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
matthewevans
left a comment
There was a problem hiding this comment.
VERDICT: approve
Test-only layer regression reviewed clean. The current head is green and labeled test.
Summary
Notes
Current main already has the parser and quantity building blocks for
PlayerFilter::HasLostTheGame; this PR keeps the change test-only and locks the parser/quantity behavior to layer application.Addresses #2930.
Verification
cargo fmt --allCARGO_INCREMENTAL=0 CARGO_TARGET_DIR=/tmp/wt-2930-frogantua-target cargo test -p engine dynamic_pt_lost_game_player_count_scales_past_one_playerCARGO_INCREMENTAL=0 CARGO_TARGET_DIR=/tmp/wt-2930-frogantua-target cargo test -p engine frogantuaCARGO_INCREMENTAL=0 CARGO_TARGET_DIR=/tmp/wt-2930-frogantua-target cargo test -p engine has_lost_the_gamegit diff --check