Skip to content

Add Rampant Frogantua lost-player pump regression#3742

Draft
dripsmvcp wants to merge 2 commits into
phase-rs:mainfrom
dripsmvcp:fix/2930-frogantua-lost-player-pump
Draft

Add Rampant Frogantua lost-player pump regression#3742
dripsmvcp wants to merge 2 commits into
phase-rs:mainfrom
dripsmvcp:fix/2930-frogantua-lost-player-pump

Conversation

@dripsmvcp

Copy link
Copy Markdown
Contributor

Summary

  • Add a runtime layer regression test for Rampant Frogantua's lost-player pump.
  • Cover the case where two players have lost the game so the dynamic +10/+10 multiplier must produce 23/23, not a flat 13/13.

Notes

Current main already has the parser and quantity building blocks for PlayerFilter::HasLostTheGame; this PR keeps the change test-only and locks the parser/quantity behavior to layer application.

Addresses #2930.

Verification

  • cargo fmt --all
  • CARGO_INCREMENTAL=0 CARGO_TARGET_DIR=/tmp/wt-2930-frogantua-target cargo test -p engine dynamic_pt_lost_game_player_count_scales_past_one_player
  • CARGO_INCREMENTAL=0 CARGO_TARGET_DIR=/tmp/wt-2930-frogantua-target cargo test -p engine frogantua
  • CARGO_INCREMENTAL=0 CARGO_TARGET_DIR=/tmp/wt-2930-frogantua-target cargo test -p engine has_lost_the_game
  • git diff --check

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new unit test dynamic_pt_lost_game_player_count_scales_past_one_player in crates/engine/src/game/layers.rs to verify that dynamic power and toughness scaling based on the count of players who have lost the game works correctly when multiple players are eliminated. It also imports PlayerFilter to support this test. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@matthewevans matthewevans added the test Add tests label Jun 18, 2026
@matthewevans matthewevans self-assigned this Jun 18, 2026

@matthewevans matthewevans left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VERDICT: approve

Test-only layer regression reviewed clean. The current head is green and labeled test.

@matthewevans matthewevans removed their assignment Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Add tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants