Skip to content

Use battlefield clicks for board choices#3745

Merged
matthewevans merged 2 commits into
mainfrom
ship/use-battlefield-clicks-for-board-choices
Jun 18, 2026
Merged

Use battlefield clicks for board choices#3745
matthewevans merged 2 commits into
mainfrom
ship/use-battlefield-clicks-for-board-choices

Conversation

@matthewevans

Copy link
Copy Markdown
Member

No description provided.

@matthewevans matthewevans enabled auto-merge June 18, 2026 20:42

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the frontend to support making game choices (such as sacrificing, tapping, returning, and crewing) directly on the battlefield instead of using modal overlays, introducing a unified boardChoice interaction system. The review feedback highlights several opportunities to clean up redundant and dead code in PermanentCard.tsx and CardChoiceModal.tsx where specific sacrifice handling and modal components have become obsolete due to the new generic boardChoice flow.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread client/src/components/board/PermanentCard.tsx Outdated
Comment thread client/src/components/board/PermanentCard.tsx
Comment thread client/src/components/board/PermanentCard.tsx Outdated
Comment thread client/src/components/modal/CardChoiceModal.tsx
@matthewevans matthewevans added this pull request to the merge queue Jun 18, 2026
Merged via the queue into main with commit efe616d Jun 18, 2026
10 checks passed
@matthewevans matthewevans deleted the ship/use-battlefield-clicks-for-board-choices branch June 18, 2026 21:48
@matthewevans matthewevans added the enhancement New feature or request label Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant