Add Yare#3748
Queued
jaso0n0818 wants to merge 5 commits into
Queued
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
matthewevans
approved these changes
Jun 18, 2026
matthewevans
left a comment
Member
There was a problem hiding this comment.
Approved after maintainer fmt-only fixup and re-check: the Yare extra-blockers parser/runtime regression is at the existing ExtraBlockers seam, the required enhancement label is present, and GitHub checks are green at 61daf32a9e9b9858d5cafe177041e3498f7ae309.
# Conflicts: # crates/engine/src/game/coverage.rs
matthewevans
approved these changes
Jun 18, 2026
matthewevans
left a comment
Member
There was a problem hiding this comment.
VERDICT: approve
Conflict resolution is limited to keeping both data-carrying coverage statics, CI is green, and the current head is labeled enhancement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds engine support for Yare.
Files changed
crates/engine/src/parser/oracle_effect/subject.rscrates/engine/src/game/coverage.rscrates/engine/tests/integration/yare_extra_blockers.rscrates/engine/tests/integration/main.rsCR references
Track
Non-developer
LLM
Model: claude-4.6-sonnet-medium-thinking
Thinking: medium
Verification
./scripts/check-parser-combinators.sh— cleancargo test -p engine --lib yare_spell_extra_blockers_up_to_two_this_turn— passcargo test -p engine --test integration yare_extra_blockers— passGate A
Anchored on
crates/engine/src/parser/oracle_effect/subject.rs:5187— existingcan block two additional creatures this combathandlercrates/engine/src/game/combat.rs:5612—extra_blockers_allows_blocking_two_attackersruntime validation patternTier: Standard
Scope Expansion
None.
Validation Failures
None.
CI Failures
None.