Skip to content

fix: Inferno Titan trigger cannot divide damage#3751

Open
jonathanchang31 wants to merge 3 commits into
phase-rs:mainfrom
jonathanchang31:fix/Inferno-Titan-trigger-cannot-divide-damage
Open

fix: Inferno Titan trigger cannot divide damage#3751
jonathanchang31 wants to merge 3 commits into
phase-rs:mainfrom
jonathanchang31:fix/Inferno-Titan-trigger-cannot-divide-damage

Conversation

@jonathanchang31

Copy link
Copy Markdown
Contributor

Summary

This PR solve the issue #3681

Related Issue

Closes: #3681

Change Type

  • Bug Fix (Investigation & Resolution)
  • New Feature
  • Breaking Change
  • Refactoring
  • Tests Added
  • Performance

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@matthewevans matthewevans left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VERDICT: request-changes

[HIGH] This PR adds intentional failing diagnostic tests instead of fixing #3681. Evidence: crates/engine/src/game/ability_utils.rs:8786 and crates/engine/tests/integration/zz_inferno_diag.rs:73 both unconditionally panic! after printing debug output. Why it matters: the branch cannot merge because the test suite is deliberately red, and it does not change the production target/distribution behavior for Inferno Titan. Suggested fix: remove the diagnostic-only tests, implement the actual divided-damage target selection fix at the production seam, and add a non-panicking regression that asserts the expected target selection/distribution state.

[MED] The regression currently observes the flow but never asserts the claimed behavior. Evidence: crates/engine/tests/integration/zz_inferno_diag.rs:51-73 loops until a waiting state, prints slot counts, then panics regardless of whether target selection or distribution is correct. Why it matters: this repeats the false-green pattern from #3725 in the opposite direction: it proves neither the bug nor the fix, so it would not protect the engine once the panic is removed. Suggested fix: assert exact state, target count, and distribution affordance for the Inferno Titan trigger, including the one/two/three target choices relevant to CR 601.2d divided damage.

@matthewevans matthewevans added the bug Bug fix label Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inferno Titan trigger cannot divide damage among multiple targets

2 participants