Skip to content

fix(parser): parse Evendo exile play permission#3753

Merged
matthewevans merged 1 commit into
phase-rs:mainfrom
dripsmvcp:fix/717-evendo-exile-cast-permission-v4
Jun 18, 2026
Merged

fix(parser): parse Evendo exile play permission#3753
matthewevans merged 1 commit into
phase-rs:mainfrom
dripsmvcp:fix/717-evendo-exile-cast-permission-v4

Conversation

@dripsmvcp

Copy link
Copy Markdown
Contributor

Summary

Fixes #717.

  • Parses Evendo Brushrazer's compact, condition-gated you may play cards exiled with ... static as the existing persistent exile play permission.
  • Preserves the as long as you've sacrificed a nontoken permanent this turn gate on the static definition.
  • Adds regression coverage for both the static parser and full Oracle dispatch path.

CR References

  • CR 113.6b
  • CR 117.1c
  • CR 305.1
  • CR 406.6
  • CR 601.2a
  • CR 601.3f

Verification

  • cargo fmt --all -- --check
  • CARGO_INCREMENTAL=0 CARGO_TARGET_DIR=/tmp/wt-717-evendo4-target cargo test -p engine persistent_exile_play_permission_evendo_sacrificed_permanent_gate
  • ./scripts/check-parser-combinators.sh
  • git diff --check HEAD~1..HEAD

Earlier full-worktree verification before the final rebase also passed cargo check --workspace --all-targets, cargo clippy --workspace --all-targets -- -D warnings, cargo test -p engine --lib -- --test-threads=1, and cargo test -p engine --tests -- --test-threads=1. The default parallel cargo test -p engine path hit the existing ai_support::tests::delve_payment_skips_state_clone_per_graveyard_candidate clone-count isolation failure; the same suite passed serially.

@dripsmvcp dripsmvcp requested a review from matthewevans as a code owner June 18, 2026 23:28
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

Copy link
Copy Markdown
Collaborator

@gemini-code-assist review

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@matthewevans matthewevans self-assigned this Jun 18, 2026
@matthewevans matthewevans added the bug Bug fix label Jun 18, 2026

@matthewevans matthewevans left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the GitHub API diff at 79208ae. This is a parser-seam fix for the Evendo compact persistent exile-play wording: the new condition is attached to StaticDefinition, and the runtime exile permission path already consumes it through active_static_definitions before offering cards. CI is green.

@matthewevans matthewevans added this pull request to the merge queue Jun 18, 2026
@matthewevans matthewevans removed their assignment Jun 18, 2026
Merged via the queue into phase-rs:main with commit 768fb89 Jun 18, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Evendo Brushrazer (EOE) exile trigger will not let you cast cards from exile — Evendo allows the exile of the cards but…

3 participants