fix(parser): parse Evendo exile play permission#3753
Merged
matthewevans merged 1 commit intoJun 18, 2026
Merged
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Collaborator
|
@gemini-code-assist review |
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
matthewevans
approved these changes
Jun 18, 2026
matthewevans
left a comment
Member
There was a problem hiding this comment.
Reviewed the GitHub API diff at 79208ae. This is a parser-seam fix for the Evendo compact persistent exile-play wording: the new condition is attached to StaticDefinition, and the runtime exile permission path already consumes it through active_static_definitions before offering cards. CI is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #717.
you may play cards exiled with ...static as the existing persistent exile play permission.as long as you've sacrificed a nontoken permanent this turngate on the static definition.CR References
Verification
cargo fmt --all -- --checkCARGO_INCREMENTAL=0 CARGO_TARGET_DIR=/tmp/wt-717-evendo4-target cargo test -p engine persistent_exile_play_permission_evendo_sacrificed_permanent_gate./scripts/check-parser-combinators.shgit diff --check HEAD~1..HEADEarlier full-worktree verification before the final rebase also passed
cargo check --workspace --all-targets,cargo clippy --workspace --all-targets -- -D warnings,cargo test -p engine --lib -- --test-threads=1, andcargo test -p engine --tests -- --test-threads=1. The default parallelcargo test -p enginepath hit the existingai_support::tests::delve_payment_skips_state_clone_per_graveyard_candidateclone-count isolation failure; the same suite passed serially.