Skip to content

fix: preserve embedding outage status for trigger endpoints - #141

Open
JulianZJN wants to merge 1 commit into
phasespace-labs:mainfrom
JulianZJN:contrib/issue-137-embedding-outage-status
Open

fix: preserve embedding outage status for trigger endpoints#141
JulianZJN wants to merge 1 commit into
phasespace-labs:mainfrom
JulianZJN:contrib/issue-137-embedding-outage-status

Conversation

@JulianZJN

Copy link
Copy Markdown

Closes #137

Summary

  • Move the shared embedding-unavailable 503 helper into palinode/api/_util.py and reuse it from the search and trigger routers.
  • Catch EmbeddingUnavailable before the generic 500 handler in /triggers and /check-triggers.
  • Leave the existing empty-embedding branches unchanged and add one regression test per endpoint.

Tests

  • uv run pytest tests/test_search_embedder_outage.py tests/test_triggers_vec_upsert.py -q (15 passed)
  • uv run ruff check palinode/ tests/ scripts/
  • uv run bandit -r palinode/ -ll (no issues identified)
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trigger endpoints return a generic 500 when the embedder is unavailable

1 participant