Skip to content

dev#172

Open
phil294 wants to merge 15 commits intophil294:masterfrom
strayge:dev
Open

dev#172
phil294 wants to merge 15 commits intophil294:masterfrom
strayge:dev

Conversation

@phil294
Copy link
Owner

@phil294 phil294 commented Nov 1, 2025

Hi @strayge, I thought this was a PR of yours but it wasn't, so I'm creating one.

There's a lot going on in your dev branch. So just in case: Do you have any plans on creating PR(s) for this stuff? Do you consider your changes ready for review? Or is it quick AI stuff? I can't even get it to run in the first place, and I'm pretty strict on code quality so getting this in might take some time.

Absolutely no problem if you don't want to deal with making PRs, just wanted to ask.

@strayge
Copy link
Contributor

strayge commented Nov 1, 2025

Do you have any plans on creating PR(s) for this stuff? Do you consider your changes ready for review?

In current state there are some bugs with staged/unstaged changes (also I do not like its implementation).
Others ones are looking good, I'm using my fork regularly.

In case you are ready to accept MRs I can start create them.

Next step is commit details.
I showed screenshots in #151 (comment) before creating MR to get some feedback, but no luck.

I can't even get it to run in the first place

There are vsix builded via CI: https://github.com/strayge/GitLG/releases/tag/dev-0.1.34-dev20250909

@phil294
Copy link
Owner Author

phil294 commented Nov 1, 2025

I showed screenshots in #151 (comment) before creating MR to get some feedback, but no luck.

ahh, I knew there was something you posted about this, there it is

In case you are ready to accept MRs I can start create them.

yes absolutely always. Sometimes it might make sense to create an issue first though, to avoid wasted efforts in case we disagree over the usefulness of a feature in the first place. But since you've got the code already, I'd say just go ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants