You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @shunf4, am I estimating correctly that you've been modifying the extension for personal usage and do not plan on actively contributing to the master branch...? Because there are some interesting things you've added and fixed, but I also see UX/code problems and some changes that I disagree with that would make it impossible to just merge it.
So unless you want to convert all your changes into separate PRs to have each of them undergo some reviewing (or if I don't hear back from you), I'll just allow myself to make one big pseudo-PR, delete from it everything I don't want, fix some code sections myself as I see fit and move on.
Note that I would like to remove SLM and CoffeeScript and move to HTML and JS, respectively, (#62) so that will make merging stuff more difficult in the future. But I'll write some scripts / use existing tooling for that, so probably no manual action would be necessary.
I made minimal changes to the code in my fork, only to bring certain features and fixes. Most of them are quite personal, but I think some of them can be taken by the upstream, like the fix for displaying moved files (path/{before/move/file.txt => after/move/file.txt}) in commit change list, using full hash to uniquely identify a commit, etc. So yes, please feel free to pick modification that look good in this PR and (if I could recall) ask me about anywhere you are unsure about its meaning.
Now that I've made most of the changes I need, I don't plan to put much efforts into my fork then. Probably not considering rebasing your big update in the future, only some small fixes and adjustments according to my need maybe.
I think the graphing algorithm has defects and I failed to completely fix them. When the history graph gets complicated, some lines are missing or not connected to the dots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @shunf4, am I estimating correctly that you've been modifying the extension for personal usage and do not plan on actively contributing to the master branch...? Because there are some interesting things you've added and fixed, but I also see UX/code problems and some changes that I disagree with that would make it impossible to just merge it.
So unless you want to convert all your changes into separate PRs to have each of them undergo some reviewing (or if I don't hear back from you), I'll just allow myself to make one big pseudo-PR, delete from it everything I don't want, fix some code sections myself as I see fit and move on.
Note that I would like to remove SLM and CoffeeScript and move to HTML and JS, respectively, (#62) so that will make merging stuff more difficult in the future. But I'll write some scripts / use existing tooling for that, so probably no manual action would be necessary.
Thanks for making your fork public! 👍