Skip to content

Add cut cell functionality #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
me-nkr wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add cut cell functionality #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions content_scripts/commands.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ Commands = {

// "Yank cell"
copy: { fn: SheetActions.copy.bind(SheetActions) },
cut: { fn: SheetActions.cut.bind(SheetActions) },
paste: { fn: SheetActions.paste.bind(SheetActions) },

// Selection
Expand Down Expand Up @@ -125,6 +126,7 @@ Commands = {

// "Yank cell"
"y,c": "copy",
"y,x": "cut",
"p": "paste",

// Selection
Expand Down
36 changes: 21 additions & 15 deletions content_scripts/sheet_actions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
SheetActions = {
menuItems: {
copy: "Copy",
cut: "Cut",
// This string with a space at the end is meant to match the button "Delete row X" where x is some number.
// There is also a "Delete rows/columns" button which we do not want to match.
deleteRow: "Delete row ",
Expand Down Expand Up @@ -98,7 +99,7 @@ SheetActions = {
// First we must open the palette; only then can we reliably get the color button that pertains to that
// color palette.
const paletteButton = document.querySelector(
(type == "cell") ? "*[aria-label='Fill color']": "*[aria-label='Text color']");
(type == "cell") ? "*[aria-label='Fill color']" : "*[aria-label='Text color']");
KeyboardUtils.simulateClick(paletteButton);

const rect = paletteButton.getBoundingClientRect();
Expand Down Expand Up @@ -144,7 +145,7 @@ SheetActions = {
// Offset this box by > 0 so we don't select the borders around the selected cell.
// NOTE(philc): I've chosen 5 here instead of 1 because > 1 is required when the document is zoomed.
const margin = 5;
return {top: box.top + margin, left: box.left + margin};
return { top: box.top + margin, left: box.left + margin };
},

selectRow() {
Expand Down Expand Up @@ -198,10 +199,10 @@ SheetActions = {
moveLeft() { UI.typeKey(KeyboardUtils.keyCodes.leftArrow); },
moveRight() { UI.typeKey(KeyboardUtils.keyCodes.rightArrow); },

moveDownAndSelect() { UI.typeKey(KeyboardUtils.keyCodes.downArrow, {shift: true}); },
moveUpAndSelect() { UI.typeKey(KeyboardUtils.keyCodes.upArrow, {shift: true}); },
moveLeftAndSelect() { UI.typeKey(KeyboardUtils.keyCodes.leftArrow, {shift: true}); },
moveRightAndSelect() { UI.typeKey(KeyboardUtils.keyCodes.rightArrow, {shift: true}); },
moveDownAndSelect() { UI.typeKey(KeyboardUtils.keyCodes.downArrow, { shift: true }); },
moveUpAndSelect() { UI.typeKey(KeyboardUtils.keyCodes.upArrow, { shift: true }); },
moveLeftAndSelect() { UI.typeKey(KeyboardUtils.keyCodes.leftArrow, { shift: true }); },
moveRightAndSelect() { UI.typeKey(KeyboardUtils.keyCodes.rightArrow, { shift: true }); },

//
// Row movement
Expand Down Expand Up @@ -332,6 +333,11 @@ SheetActions = {
this.unselectRow();
},

cut() {
this.clickMenu(this.menuItems.cut);
this.unselectRow();
},

paste() {
this.clickMenu(this.menuItems.paste);
this.unselectRow();
Expand All @@ -352,8 +358,8 @@ SheetActions = {

// The approximate number of visible rows. It's probably possible to compute this precisely.
visibleRowCount() {
return Math.ceil(document.querySelector(".grid-scrollable-wrapper").offsetHeight / this.rowHeight());
},
return Math.ceil(document.querySelector(".grid-scrollable-wrapper").offsetHeight / this.rowHeight());
},

// NOTE(philc): It would be nice to improve these scrolling commands. They're somewhat slow and imprecise.
scrollHalfPageDown() {
Expand All @@ -373,13 +379,13 @@ SheetActions = {
scrollToTop() {
// TODO(philc): This may not work on Linux or Windows since it uses the meta key. Replace with CTRL on
// those platforms?
UI.typeKey(KeyboardUtils.keyCodes.home, {meta: true});
UI.typeKey(KeyboardUtils.keyCodes.home, { meta: true });
},

scrollToBottom() {
// End takes you to the bottom-right corner of the sheet, which doesn't mirror gg. So use Left afterwards.
UI.typeKey(KeyboardUtils.keyCodes.end, {meta: true});
UI.typeKey(KeyboardUtils.keyCodes.leftArrow, {meta: true});
UI.typeKey(KeyboardUtils.keyCodes.end, { meta: true });
UI.typeKey(KeyboardUtils.keyCodes.leftArrow, { meta: true });
},

//
Expand Down Expand Up @@ -449,10 +455,10 @@ SheetActions = {
// implement increaes font / decrease font commands.
getFontSizeMenu() { return this.getMenuItem("6").parentNode; },
activateFontSizeMenu() {
KeyboardUtils.simulateClick(this.getMenuItem("Font size"));
// It's been shown; hide it again.
this.getFontSizeMenu().style.display = "none";
},
KeyboardUtils.simulateClick(this.getMenuItem("Font size"));
// It's been shown; hide it again.
this.getFontSizeMenu().style.display = "none";
},

setFontSize10() {
this.activateFontSizeMenu();
Expand Down