Skip to content

fix: use documentReady instead of documentComplete in HUD methods #4911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xiaolongnk wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −4
Open

fix: use documentReady instead of documentComplete in HUD methods #4911

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d6ffc3
fix: use documentReady instead of documentComplete for clipboard oper…
xiaolongnk Jun 12, 2026
6ecbb24
fix: use documentReady for all HUD ops to unblock on loading pages
xiaolongnk Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions content_scripts/hud.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ const HUD = {

// duration - if omitted, the message will show until dismissed.
async show(text, duration) {
await DomUtils.documentComplete();
await DomUtils.documentReady();
clearTimeout(this._showForDurationTimerId);
// @hudUI.activate will take charge of making it visible
await this.init(false);
Expand All @@ -88,7 +88,7 @@ const HUD = {

async showFindMode(findMode = null) {
this.findMode = findMode;
await DomUtils.documentComplete();
await DomUtils.documentReady();
await this.init();
this.hudUI.show({ name: "showFindMode" });
this.tween.fade(1.0, 150);
Expand Down Expand Up @@ -177,14 +177,14 @@ const HUD = {
// * events.
// * the HUD shouldn't be active for this frame while any of the copy/paste commands are running.
async copyToClipboard(text) {
await DomUtils.documentComplete();
await DomUtils.documentReady();
await this.init();
this.hudUI.postMessage({ name: "copyToClipboard", data: text });
},

async pasteFromClipboard(pasteListener) {
this.pasteListener = pasteListener;
await DomUtils.documentComplete();
await DomUtils.documentReady();
await this.init();
this.tween.fade(0, 0);
this.hudUI.postMessage({ name: "pasteFromClipboard" });
Expand Down